Skip to content
This repository has been archived by the owner on Feb 19, 2019. It is now read-only.

write to the correctly scoped chocolateyErrored variable #658

Closed
wants to merge 2 commits into from

Conversation

mwrock
Copy link
Contributor

@mwrock mwrock commented Jan 12, 2015

Exceptions raised in chocolateyInstall.ps1 are not resulting in a non-zero exit code because it is writing to the $chocolateyErrored variable in a different scope from where it was created. To illustrate, the added test in this PR will fail if Chocolatey-Nuget.ps1 is reverted.

@mwrock mwrock changed the title write to the correctly scopped chocolateyErrored variable write to the correctly scoped chocolateyErrored variable Jan 12, 2015
…se chocolatey is intercepted from a module (like boxstarter)
@ferventcoder
Copy link
Contributor

None of this code exists in choco.exe :(

@mwrock
Copy link
Contributor Author

mwrock commented Jan 12, 2015

Right but it fixes the PS version. When is choco.exe due?

@ferventcoder
Copy link
Contributor

January 15th-ish

@mwrock
Copy link
Contributor Author

mwrock commented Jan 12, 2015

Oh ok. As a full release or alpha/beta?

Sent from my Windows Phone


From: Rob Reynoldsmailto:[email protected]
Sent: ‎1/‎12/‎2015 8:46 AM
To: chocolatey/chocolateymailto:[email protected]
Cc: Matt Wrockmailto:[email protected]
Subject: Re: [chocolatey] write to the correctly scoped chocolateyErrored variable (#658)

January 15th-ish


Reply to this email directly or view it on GitHub:
#658 (comment)

@ferventcoder
Copy link
Contributor

Well likely a beta.

On Monday, January 12, 2015, Matt Wrock [email protected] wrote:

Oh ok. As a full release or alpha/beta?

Sent from my Windows Phone


From: Rob Reynolds<mailto:[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
Sent: ‎1/‎12/‎2015 8:46 AM
To: chocolatey/chocolatey<mailto:[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
Cc: Matt Wrock<mailto:[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
Subject: Re: [chocolatey] write to the correctly scoped chocolateyErrored
variable (#658)

January 15th-ish


Reply to this email directly or view it on GitHub:
#658 (comment)


Reply to this email directly or view it on GitHub
#658 (comment).

Rob
"Be passionate in all you do"

http://devlicio.us/blogs/rob_reynolds
http://ferventcoder.com
http://twitter.com/ferventcoder

@mwrock
Copy link
Contributor Author

mwrock commented Jan 12, 2015

ok cool. Wasn't sure if there is stuff out there that would be highly impacted by a lack of a non-zero error code. I pushed a work around in boxstarter last night so its not affected.

@ferventcoder
Copy link
Contributor

I will likely go ahead on this one.

@ferventcoder
Copy link
Contributor

This looks like a fix for #568 (ha, transposed! Wild!)

@ferventcoder
Copy link
Contributor

Merged into stable at bcea921

@matt-richardson
Copy link

Thanks @ferventcoder!

@ferventcoder
Copy link
Contributor

Released as well a little while ago.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants